Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Uid file v3 #1100

Merged
merged 2 commits into from
Jan 30, 2024
Merged

feat: Uid file v3 #1100

merged 2 commits into from
Jan 30, 2024

Conversation

PhilippeWeidmann
Copy link
Member

No description provided.

@PhilippeWeidmann PhilippeWeidmann added this to the APIV3 milestone Jan 19, 2024
@PhilippeWeidmann PhilippeWeidmann requested a review from a team as a code owner January 19, 2024 13:59
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

adrien-coye
adrien-coye reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Just one question.

adrien-coye
adrien-coye approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback 🙌

Base automatically changed from menu-v3 to releaseAPIV3 January 30, 2024 13:29
@PhilippeWeidmann PhilippeWeidmann merged commit c2fea93 into releaseAPIV3 Jan 30, 2024
5 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the uid-file-v3 branch January 30, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien-coye adrien-coye adrien-coye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilippeWeidmann @adrien-coye