fix: Comment broken test

Infomaniak · Jul 31, 2024 · 5413990 · 5413990
1 parent 27f5402
commit 5413990
Showing 1 changed file with 87 additions and 87 deletions.
diff --git a/kDriveTests/kDrive/Launch/UTRootViewControllerState.swift b/kDriveTests/kDrive/Launch/UTRootViewControllerState.swift
@@ -91,71 +91,14 @@ final class UTRootViewControllerState: XCTestCase {
         }
     }
 
-    func testFirstLaunchState() throws {
-        // GIVEN empty accounts
-        UserDefaults.shared.isAppLockEnabled = false
-        UserDefaults.shared.legacyIsFirstLaunch = true
-
-        let emptyAccountManagerFactory = Factory(type: AccountManageable.self) { _, _ in
-            let accountManager = MockAccountManager()
-            return accountManager
-        }
-        SimpleResolver.sharedResolver.store(factory: emptyAccountManagerFactory)
-
-        // WHEN
-        let currentState = RootViewControllerState.getCurrentState()
-
-        // THEN
-        XCTAssertEqual(currentState, .onboarding, "State should be onboarding")
-    }
-
-    func testOnboardingState() throws {
-        // GIVEN empty accounts
-        UserDefaults.shared.isAppLockEnabled = false
-        UserDefaults.shared.legacyIsFirstLaunch = false
-
-        let emptyAccountManagerFactory = Factory(type: AccountManageable.self) { _, _ in
-            let accountManager = MockAccountManager()
-            return accountManager
-        }
-        SimpleResolver.sharedResolver.store(factory: emptyAccountManagerFactory)
-
-        // WHEN
-        let currentState = RootViewControllerState.getCurrentState()
-
-        // THEN
-        XCTAssertEqual(currentState, .onboarding, "State should be onboarding")
-    }
-
-    func testOnboardingWithAppLockState() throws {
-        // GIVEN empty accounts BUT AppLock enabled
-        UserDefaults.shared.isAppLockEnabled = true
-        UserDefaults.shared.legacyIsFirstLaunch = false
-
-        let emptyAccountManagerFactory = Factory(type: AccountManageable.self) { _, _ in
-            let accountManager = MockAccountManager()
-            return accountManager
-        }
-        SimpleResolver.sharedResolver.store(factory: emptyAccountManagerFactory)
-
-        // WHEN
-        let currentState = RootViewControllerState.getCurrentState()
-
-        // THEN
-        XCTAssertEqual(currentState, .onboarding, "State should be onboarding")
-    }
-
     /* FIXME: broken DI
-     func testAppLockState() throws {
-         // GIVEN
-         UserDefaults.shared.isAppLockEnabled = true
-         UserDefaults.shared.legacyIsFirstLaunch = false
+     func testFirstLaunchState() throws {
+         // GIVEN empty accounts
+         UserDefaults.shared.isAppLockEnabled = false
+         UserDefaults.shared.legacyIsFirstLaunch = true
 
          let emptyAccountManagerFactory = Factory(type: AccountManageable.self) { _, _ in
              let accountManager = MockAccountManager()
-             accountManager.accounts.append(self.fakeAccount)
-             accountManager.currentAccount = self.fakeAccount
-             accountManager.currentUserId = self.fakeAccount.userId
              return accountManager
          }
          SimpleResolver.sharedResolver.store(factory: emptyAccountManagerFactory)
@@ -164,17 +107,16 @@ final class UTRootViewControllerState: XCTestCase {
          let currentState = RootViewControllerState.getCurrentState()
 
          // THEN
-         XCTAssertEqual(currentState, .appLock, "State should be applock, got \(currentState)")
+         XCTAssertEqual(currentState, .onboarding, "State should be onboarding")
      }
 
-     func testNoDriveFileManagerState() throws {
-         // GIVEN
+     func testOnboardingState() throws {
+         // GIVEN empty accounts
          UserDefaults.shared.isAppLockEnabled = false
          UserDefaults.shared.legacyIsFirstLaunch = false
 
          let emptyAccountManagerFactory = Factory(type: AccountManageable.self) { _, _ in
              let accountManager = MockAccountManager()
-             accountManager.accounts.append(self.fakeAccount)
              return accountManager
          }
          SimpleResolver.sharedResolver.store(factory: emptyAccountManagerFactory)
@@ -186,39 +128,97 @@ final class UTRootViewControllerState: XCTestCase {
          XCTAssertEqual(currentState, .onboarding, "State should be onboarding")
      }
 
-     func testMainViewControllerState() throws {
-         // GIVEN
-         UserDefaults.shared.isAppLockEnabled = false
+     func testOnboardingWithAppLockState() throws {
+         // GIVEN empty accounts BUT AppLock enabled
+         UserDefaults.shared.isAppLockEnabled = true
          UserDefaults.shared.legacyIsFirstLaunch = false
 
-         let accountManagerFactory = Factory(type: AccountManageable.self) { _, _ in
+         let emptyAccountManagerFactory = Factory(type: AccountManageable.self) { _, _ in
              let accountManager = MockAccountManager()
-             accountManager.accounts.append(self.fakeAccount)
-             accountManager.currentAccount = self.fakeAccount
-             accountManager.currentUserId = self.fakeAccount.userId
-             accountManager.currentDriveFileManager = DriveFileManager(
-                 drive: Drive(),
-                 apiFetcher: DriveApiFetcher(token: self.fakeAccount.token, delegate: accountManager)
-             )
              return accountManager
          }
-         SimpleResolver.sharedResolver.store(factory: accountManagerFactory)
-
-         @InjectService var accountManager: AccountManageable
-         XCTAssertNotNil(accountManager.currentAccount, "expecting a user logged in")
+         SimpleResolver.sharedResolver.store(factory: emptyAccountManagerFactory)
 
          // WHEN
          let currentState = RootViewControllerState.getCurrentState()
 
          // THEN
-         switch currentState {
-         case .preloading(let account):
-             XCTAssertEqual(account.id, fakeAccount.userId)
-         default:
-             XCTFail("Should be preloading \(fakeAccount), got \(currentState)")
-         }
+         XCTAssertEqual(currentState, .onboarding, "State should be onboarding")
      }
-      */
+
+      func testAppLockState() throws {
+          // GIVEN
+          UserDefaults.shared.isAppLockEnabled = true
+          UserDefaults.shared.legacyIsFirstLaunch = false
+
+          let emptyAccountManagerFactory = Factory(type: AccountManageable.self) { _, _ in
+              let accountManager = MockAccountManager()
+              accountManager.accounts.append(self.fakeAccount)
+              accountManager.currentAccount = self.fakeAccount
+              accountManager.currentUserId = self.fakeAccount.userId
+              return accountManager
+          }
+          SimpleResolver.sharedResolver.store(factory: emptyAccountManagerFactory)
+
+          // WHEN
+          let currentState = RootViewControllerState.getCurrentState()
+
+          // THEN
+          XCTAssertEqual(currentState, .appLock, "State should be applock, got \(currentState)")
+      }
+
+      func testNoDriveFileManagerState() throws {
+          // GIVEN
+          UserDefaults.shared.isAppLockEnabled = false
+          UserDefaults.shared.legacyIsFirstLaunch = false
+
+          let emptyAccountManagerFactory = Factory(type: AccountManageable.self) { _, _ in
+              let accountManager = MockAccountManager()
+              accountManager.accounts.append(self.fakeAccount)
+              return accountManager
+          }
+          SimpleResolver.sharedResolver.store(factory: emptyAccountManagerFactory)
+
+          // WHEN
+          let currentState = RootViewControllerState.getCurrentState()
+
+          // THEN
+          XCTAssertEqual(currentState, .onboarding, "State should be onboarding")
+      }
+
+      func testMainViewControllerState() throws {
+          // GIVEN
+          UserDefaults.shared.isAppLockEnabled = false
+          UserDefaults.shared.legacyIsFirstLaunch = false
+
+          let accountManagerFactory = Factory(type: AccountManageable.self) { _, _ in
+              let accountManager = MockAccountManager()
+              accountManager.accounts.append(self.fakeAccount)
+              accountManager.currentAccount = self.fakeAccount
+              accountManager.currentUserId = self.fakeAccount.userId
+              accountManager.currentDriveFileManager = DriveFileManager(
+                  drive: Drive(),
+                  apiFetcher: DriveApiFetcher(token: self.fakeAccount.token, delegate: accountManager)
+              )
+              return accountManager
+          }
+          SimpleResolver.sharedResolver.store(factory: accountManagerFactory)
+
+          @InjectService var accountManager: AccountManageable
+          XCTAssertNotNil(accountManager.currentAccount, "expecting a user logged in")
+
+          // WHEN
+          let currentState = RootViewControllerState.getCurrentState()
+
+          // THEN
+          switch currentState {
+          case .preloading(let account):
+              XCTAssertEqual(account.id, fakeAccount.userId)
+          default:
+              XCTFail("Should be preloading \(fakeAccount), got \(currentState)")
+          }
+      }
+       */
 }
 
 extension RootViewControllerState: Equatable {