Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BrandTopAppBar in all screens & tablet mode #57

Merged
merged 14 commits into from
Sep 25, 2024
Merged

Conversation

KevinBoulongne
Copy link
Contributor

@KevinBoulongne KevinBoulongne commented Sep 16, 2024

Depends on #66

@KevinBoulongne KevinBoulongne changed the base branch from main to fix-settings-option-style September 19, 2024 13:43
@LunarX LunarX force-pushed the fix-settings-option-style branch from e706055 to 98fc272 Compare September 20, 2024 07:16
Base automatically changed from fix-settings-option-style to main September 20, 2024 07:18
@KevinBoulongne KevinBoulongne force-pushed the top-app-bar branch 4 times, most recently from 28d61aa to fab625d Compare September 20, 2024 12:12
@KevinBoulongne KevinBoulongne force-pushed the top-app-bar branch 2 times, most recently from b21a83b to f1eadde Compare September 23, 2024 12:51
@KevinBoulongne KevinBoulongne changed the title Add BrandTobAppBar in all screens & tablet mode Add BrandTopAppBar in all screens & tablet mode Sep 24, 2024
Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's too much space between the top app bar and the main content of the screen that's been added with this modification

@KevinBoulongne KevinBoulongne changed the base branch from main to tablet-utils September 25, 2024 09:33
@KevinBoulongne KevinBoulongne changed the base branch from tablet-utils to main September 25, 2024 11:04
Copy link

This PR/issue depends on:

@KevinBoulongne KevinBoulongne requested a review from a team September 25, 2024 11:09
Copy link

@KevinBoulongne KevinBoulongne merged commit 3addd91 into main Sep 25, 2024
4 checks passed
@KevinBoulongne KevinBoulongne deleted the top-app-bar branch September 25, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants