Skip to content

Commit

Permalink
review: Clean code
Browse files Browse the repository at this point in the history
  • Loading branch information
KevinBoulongne committed Nov 1, 2024
1 parent b9e04a7 commit 1f0f333
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ private fun FileItemContent(
) {
Box(
modifier = Modifier
.weight(1f)
.weight(1.0f)
.fillMaxWidth()
.background(SwissTransferTheme.materialColors.surfaceContainerHighest)
) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,7 @@ import java.util.UUID

@OptIn(ExperimentalLayoutApi::class)
@Composable
fun TransferItem(
transfer: TransferUi,
onClick: () -> Unit,
) {
fun TransferItem(transfer: TransferUi, onClick: () -> Unit) {
Card(
onClick = onClick,
colors = CardDefaults.cardColors(containerColor = SwissTransferTheme.materialColors.surfaceContainerHighest),
Expand All @@ -58,9 +55,7 @@ fun TransferItem(
verticalAlignment = Alignment.CenterVertically,
) {

Column(
modifier = Modifier.weight(1.0f),
) {
Column(modifier = Modifier.weight(1.0f)) {

Text(
text = Date(transfer.createdDateTimestamp).format(FORMAT_DATE_TITLE),
Expand Down Expand Up @@ -159,8 +154,7 @@ private fun Preview() {
localPath = null,
),
),

),
),
onClick = {},
)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,7 @@ fun TransferItemList(
contentType = { transfers[it] },
itemContent = {
val transfer = transfers[it]
TransferItem(
transfer = transfer,
onClick = { onClick(transfer) },
)
TransferItem(transfer) { onClick(transfer) }
},
)
}
Expand Down Expand Up @@ -163,10 +160,7 @@ private fun Preview() {

SwissTransferTheme {
Surface {
TransferItemList(
transfers = transfers,
onClick = {},
)
TransferItemList(transfers = transfers, onClick = {})
}
}
}

0 comments on commit 1f0f333

Please sign in to comment.