Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store slugs for DOIs #1088

Merged
merged 1 commit into from
Feb 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions isic/core/migrations/0006_doi_slug.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Generated by Django 5.1.5 on 2025-02-18 15:09

from django.db import migrations, models


class Migration(migrations.Migration):
dependencies = [
("core", "0005_doi_bundle"),
]

operations = [
migrations.AddField(
model_name="doi",
name="slug",
field=models.SlugField(blank=True, max_length=150, null=True, unique=True),
),
]
29 changes: 29 additions & 0 deletions isic/core/migrations/0007_alter_doi_slug.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Generated by Django 5.1.5 on 2025-02-18 15:09

from django.db import migrations, models
from django.utils.text import slugify


def populate_doi_slugs(apps, schema_editor):
Doi = apps.get_model("core", "Doi")
for doi in Doi.objects.all():
doi.slug = slugify(doi.collection.name)
doi.save()


class Migration(migrations.Migration):
dependencies = [
("core", "0006_doi_slug"),
]

operations = [
migrations.RunPython(
populate_doi_slugs,
elidable=True,
),
migrations.AlterField(
model_name="doi",
name="slug",
field=models.SlugField(max_length=150, unique=True),
),
]
2 changes: 1 addition & 1 deletion isic/core/models/doi.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@


class Doi(TimeStampedModel):
# TODO: figure out which fields to store here
id = models.CharField(
max_length=30, primary_key=True, validators=[RegexValidator(r"^\d+\.\d+/\d+$")]
)
slug = models.SlugField(max_length=150, unique=True)
creator = models.ForeignKey(User, on_delete=models.RESTRICT)

url = models.CharField(max_length=200)
Expand Down
5 changes: 4 additions & 1 deletion isic/core/services/collection/doi.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
from django.core.files import File
from django.db import connection, transaction
from django.template.loader import render_to_string
from django.utils.text import slugify
import requests
from requests.exceptions import HTTPError

Expand Down Expand Up @@ -138,7 +139,9 @@ def collection_create_doi(*, user: User, collection: Collection) -> Doi:

with transaction.atomic():
# First, create the local DOI record to validate uniqueness within our known set
doi = Doi(id=doi_id, creator=user, url=f"https://doi.org/{doi_id}")
doi = Doi(
id=doi_id, slug=slugify(collection.name), creator=user, url=f"https://doi.org/{doi_id}"
)
doi.full_clean()
doi.save()

Expand Down