Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outcome_benign_malignant #1052

Merged
merged 1 commit into from
Jan 21, 2025
+0 −10
Merged

Remove outcome_benign_malignant #1052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions isic/core/templates/core/lesion_detail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,6 @@
<dt class="text-gray-500">Outcome Diagnosis</dt>
<dd class="text-gray-900">{{ lesion.outcome_diagnosis|default:"-" }}</dd>
</div>

<div class="py-3 flex justify-between text-sm font-medium">
<dt class="text-gray-500">Outcome Benign/Malignant</dt>
<dd class="text-gray-900">{{ lesion.outcome_benign_malignant }}</dd>
</div>
</dl>
</div>
</div>
Expand Down
1 change: 0 additions & 1 deletion isic/ingest/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ class Meta:
longitudinally_monitored: bool
index_image_id: str | None
outcome_diagnosis: str | None
outcome_benign_malignant: str | None

@staticmethod
def resolve_images(obj: Lesion) -> list[ImageOut]:
Expand Down
2 changes: 0 additions & 2 deletions isic/ingest/models/lesion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ class LesionInfo(TypedDict):

images_count: int
outcome_diagnosis: str
outcome_benign_malignant: str
longitudinally_monitored: bool


Expand All @@ -97,7 +96,6 @@ def with_total_info(self):
partition_by=[F("id")],
),
outcome_diagnosis=F("fq_diagnosis"),
outcome_benign_malignant=F("accessions__benign_malignant"),
)
# this is hard to do without defining a new type of expression because django
# wants to perform group by on subqueries.
Expand Down
2 changes: 0 additions & 2 deletions isic/ingest/tests/test_api_lesion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ def test_api_lesion_completeness(client, lesion_factory, image_factory):
lesion = lesion_factory()
image = image_factory(
accession__lesion=lesion,
accession__benign_malignant="malignant",
accession__fq__diagnosis="melanoma",
accession__acquisition_day=1,
public=True,
Expand All @@ -113,7 +112,6 @@ def test_api_lesion_completeness(client, lesion_factory, image_factory):
resp.json()["results"][0]["outcome_diagnosis"]
== DiagnosisEnum.malignant_malignant_melanocytic_proliferations_melanoma_melanoma_invasive
)
assert resp.json()["results"][0]["outcome_benign_malignant"] == "malignant"

# verify longitudinally_monitored
image_factory(
Expand Down
Loading