Merge pull request #1059 from ImageMarkup/remove-ruff-rule

ImageMarkup · Jan 22, 2025 · 07385a4 · 07385a4
2 parents d895ac0 + 972c485
commit 07385a4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/.git-blame-ignore-revs b/.git-blame-ignore-revs
@@ -8,3 +8,5 @@ b086108f04296e2a23c6943fb81cc5d158923cfd
 874f3d712c1ab776491a00b4f87db904fd4e4bce
 # migrated to ruff
 8980ca2546e01d1dda90aeff9e18630fe10903e6
+# remove ret506 ruff rule
+6b3959ee3476ffb197c2fc1bf318c32cd20db6e4
diff --git a/isic/studies/forms.py b/isic/studies/forms.py
@@ -31,7 +31,7 @@ def __init__(self, *args, **kwargs):
             # this is a hack because passing a per-question version of recent diagnoses is
             # unreasonably difficult.
             raise ValueError("Only one diagnosis question is allowed per study.")
-        elif num_diagnosis_questions == 1:  # noqa: RET506
+        elif num_diagnosis_questions == 1:
             # the study and user are necessary for diagnosis questions in order to compute
             # the recently used diagnoses
             self.study = kwargs.pop("study")

diff --git a/pyproject.toml b/pyproject.toml
@@ -36,6 +36,7 @@ ignore = [
 
   # Excessive
   "RET503", # implict return
+  "RET506", # else after raise
   "PLR2004", # magic value used in comparison
 
   # Try to fix upstream