Buffer overflow extracting the thumbnail of certain RAW photos - Fixes #3 #4
Conversation
…ImageMagick#3 Ideally the DNG parser should be fixed, but meanwhile and as a safety measure we shall ensure such buffer overflow does not happens in general...
|
Found this PR way to late but can you explain after almost 3 years why this fixes an overflow? |
|
Better later than never, but this will be a good memory exercise indeed. I think you mean besides what was described in #3 ? there you can find the details, although i am failing to remember how this was fixing the overflow exactly. |
|
It looks like this check |
|
It will be a matter of re-testing the pointed DNG file, perhaps the embedded thumbnail was truncated and a size offset resulting on allocating more memory than the file itself, or something of the like (?) |
Ideally the DNG parser should be fixed, but meanwhile and as a safety measure we shall ensure such buffer overflow does not happens in general...