[#431] Fix warnings in area-related services.

Fixes: * Undefined variable: string * Undefined index: sid
Igalia · Feb 7, 2022 · bc8dbff · bc8dbff
1 parent af48580
commit bc8dbff
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 10 deletions.
diff --git a/web/services/createAreasService.php b/web/services/createAreasService.php
@@ -116,9 +116,7 @@
 
             }
 
-
-
-        if (!$string)
+        if (!isset($string))
         {
 
             $string = "<return service='createAreas'><ok>Operation Success!</ok><areas>";

diff --git a/web/services/deleteAreasService.php b/web/services/deleteAreasService.php
@@ -116,9 +116,7 @@
 
             }
 
-
-
-        if (!$string)
+        if (!isset($string))
             $string = "<return service='deleteAreas'><ok>Operation Success!</ok></return>";
 
     } while (false);

diff --git a/web/services/getAllAreasService.php b/web/services/getAllAreasService.php
@@ -31,7 +31,7 @@
     include_once(PHPREPORT_ROOT . '/model/facade/AdminFacade.php');
     include_once(PHPREPORT_ROOT . '/model/vo/AreaVO.php');
 
-    $sid = $_GET['sid'];
+    $sid = $_GET['sid'] ?? NULL;
 
     do {
         /* We check authentication and authorization */

diff --git a/web/services/updateAreasService.php b/web/services/updateAreasService.php
@@ -125,9 +125,7 @@
 
             }
 
-
-
-        if (!$string)
+        if (!isset($string))
         {
 
             $string = "<return service='updateAreas'><ok>Operation Success!</ok><areas>";
-Original file line number
+Diff line change
@@ Expand Up / @@ -116,9 +116,7 @@ @@
                 }
-            if (!$string)
+            if (!isset($string))
             {
                 $string = "<return service='createAreas'><ok>Operation Success!</ok><areas>";
@@ Expand Down @@