Skip to content

Commit

Permalink
[#431] Fix several 'undefined variable' warnings.
Browse files Browse the repository at this point in the history
Fixes this warning which popped up several times:
PHP Notice:  Undefined variable: login in
/var/www/html/phpreport/web/viewProjectDetails.php on line 345

The login parameter was ignored by the service, and the local $login
var didn't even have a value.
  • Loading branch information
jaragunde committed Dec 1, 2018
1 parent 0f30c55 commit bbfb510
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions web/viewProjectDetails.php
Original file line number Diff line number Diff line change
Expand Up @@ -342,8 +342,6 @@
stateId: 'projectUserCustomerGrid',
storeUrl: 'services/getProjectUserCustomerReportJsonService.php?<?php

echo "login=" . $login;

if ($sid!="")
echo "&sid=" . $sid;

Expand Down Expand Up @@ -408,8 +406,6 @@
stateId: 'projectUserStoryGrid',
storeUrl: 'services/getProjectUserStoryReportJsonService.php?<?php

echo "login=" . $login;

if ($sid!="")
echo "&sid=" . $sid;

Expand Down Expand Up @@ -473,8 +469,6 @@
id: 'projectUserWeeklyHoursGrid',
stateId: 'projectUserWeeklyHoursGrid',
storeUrl: 'services/getProjectUserWeeklyHoursReportJsonService.php?<?php

echo "login=" . $login;
echo "&pid=" . $pid;?>',
rowNumberer: false,
columnLines: true,
Expand Down Expand Up @@ -543,8 +537,6 @@

grid.store.proxy.conn.url= 'services/getProjectUserCustomerReportJsonService.php?<?php

echo "login=" . $login;

if ($sid!="")
echo "&sid=" . $sid;

Expand All @@ -560,8 +552,6 @@

grid2.store.proxy.conn.url= 'services/getProjectUserStoryReportJsonService.php?<?php

echo "login=" . $login;

if ($sid!="")
echo "&sid=" . $sid;

Expand All @@ -575,7 +565,6 @@

grid3.store.proxy.conn.url= 'services/getProjectUserWeeklyHoursReportJsonService.php?<?php

echo "login=" . $login;
echo "&pid=" . $pid;

?>&init=' + init.getFullYear() + "-" + (init.getMonth()+1) + "-" + init.getDate() + "&end=" + end.getFullYear() + "-" + (end.getMonth() + 1) + "-" + end.getDate();
Expand Down

0 comments on commit bbfb510

Please sign in to comment.