[#431] Fix PHP warnings in customer management page.

Fixes: * Undefined index: sid, uid, active, login, order * Undefined variable: string
Igalia · Jan 25, 2022 · 06a1e57 · 06a1e57
1 parent 04bd184
commit 06a1e57
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 32 deletions.
diff --git a/web/services/createCustomersService.php b/web/services/createCustomersService.php
@@ -135,9 +135,6 @@
 
         } while ($parser->read());
 
-        //var_dump($createCustomers);
-
-
         if (count($createCustomers) >= 1)
             foreach((array)$createCustomers as $createCustomer)
             {
@@ -149,9 +146,7 @@
 
             }
 
-
-
-        if (!$string)
+        if (!isset($string))
         {
 
             $string = "<return service='createCustomers'><ok>Operation Success!</ok><customers>";

diff --git a/web/services/deleteCustomersService.php b/web/services/deleteCustomersService.php
@@ -108,9 +108,6 @@
 
         } while ($parser->read());
 
-        //var_dump($deleteCustomers);
-
-
         if (count($deleteCustomers) >= 1)
             foreach((array)$deleteCustomers as $deleteCustomer)
             {
@@ -122,9 +119,7 @@
 
             }
 
-
-
-        if (!$string)
+        if (!isset($string))
             $string = "<return service='deleteCustomers'><ok>Operation Success!</ok></return>";
 
     } while (false);

diff --git a/web/services/getAllSectorsService.php b/web/services/getAllSectorsService.php
@@ -31,7 +31,7 @@
     include_once(PHPREPORT_ROOT . '/model/facade/CustomersFacade.php');
     include_once(PHPREPORT_ROOT . '/model/vo/SectorVO.php');
 
-    $sid = $_GET['sid'];
+    $sid = $_GET['sid'] ?? NULL;
 
     do {
         /* We check authentication and authorization */

diff --git a/web/services/getUserCustomersService.php b/web/services/getUserCustomersService.php
@@ -31,23 +31,15 @@
     include_once(PHPREPORT_ROOT . '/model/facade/CustomersFacade.php');
     include_once(PHPREPORT_ROOT . '/model/vo/UserVO.php');
 
-    $userLogin = $_GET['uid'];
+    $userLogin = $_GET['uid'] ?? "";
 
-    $active = $_GET['active'];
-
-    if (strtolower($active) == "true")
-    $active = True;
-    else
     $active = False;
+    if (isset($_GET['active']) && strtolower($_GET['active']) == "true")
+        $active = True;
 
-    $login = $_GET['login'];
-
-    $sid = $_GET['sid'];
-
-    $order = $_GET['order'];
+    $sid = $_GET['sid'] ?? NULL;
 
-    if ($order == '')
-        $order = 'id';
+    $order = $_GET['order'] ?? "id";
 
     do {
         /* We check authentication and authorization */

diff --git a/web/services/updateCustomersService.php b/web/services/updateCustomersService.php
@@ -144,9 +144,6 @@
 
         } while ($parser->read());
 
-        //var_dump($updateCustomers);
-
-
         if (count($updateCustomers) >= 1)
             foreach((array)$updateCustomers as $updateCustomer)
             {
@@ -158,9 +155,7 @@
 
             }
 
-
-
-        if (!$string)
+        if (!isset($string))
         {
 
             $string = "<return service='updateCustomers'><ok>Operation Success!</ok><customers>";