[RFC] Add chrome(ium) support to extension #93
+77
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add support for Chromium based browsers to the extension.
I have tested this on Firefox 124.0.1 and Chromium 123.0.6312.86.
While testing i encountered a Chromium (bug?) behavior that crashed the extension if chrome.runtime.sendNativeMessage was not awaited. This works fine on Firefox so i added the workaround that makes the popup menu take a second to load on Chromium. This shouldn't be a big deal.
The only needed change to package for chromium is to replace the manifest.json with the manifest-chrome.json and adjust the native extension once you get a release id on the chrome store.
Anyway, this is just for your consideration. Thanks for your work.