Skip to content

Commit

Permalink
[shortfin] Enable building Rust deps on Linux (nod-ai#619)
Browse files Browse the repository at this point in the history
Sets up Rust to build shortfin with `SHORTFIN_ENABLE_TOKENIZERS` set to
`ON` on Linux. At the moment, building with Rust is limited to Linux as
there are build failures on Windows (see issue nod-ai#620).
  • Loading branch information
marbre authored and IanNod committed Dec 17, 2024
1 parent a4e6a85 commit e2370dc
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion .github/workflows/ci-libshortfin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
- name: Ubuntu (Clang)(full)
runs-on: ubuntu-24.04
cmake-options:
-DCMAKE_C_COMPILER=clang-18 -DCMAKE_CXX_COMPILER=clang++-18 -DCMAKE_LINKER_TYPE=LLD
-DCMAKE_C_COMPILER=clang-18 -DCMAKE_CXX_COMPILER=clang++-18 -DCMAKE_LINKER_TYPE=LLD -DSHORTFIN_ENABLE_TOKENIZERS=ON
additional-packages: clang lld
- name: Ubuntu (Clang)(host-only)
runs-on: ubuntu-24.04
Expand Down Expand Up @@ -88,6 +88,14 @@ jobs:
if: "runner.os == 'Windows'"
uses: ilammy/msvc-dev-cmd@0b201ec74fa43914dc39ae48a89fd1d8cb592756 # v1.13.0

- name: Setup Rust
# For now, `SHORTFIN_ENABLE_TOKENIZERS` is only enabled for 'Ubuntu (Clang)(full)'.
# TODO(#620): Enable on Windows.
if: ${{ matrix.name == 'Ubuntu (Clang)(full)'}}
uses: dtolnay/rust-toolchain@315e265cd78dad1e1dcf3a5074f6d6c47029d5aa # master branch (Nov 18, 2024)
with:
toolchain: stable

- name: Checkout IREE repo
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
Expand Down

0 comments on commit e2370dc

Please sign in to comment.