Fix building on Win32 #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahyar Koshkouei <[email protected]>
Signed-off-by: Mahyar Koshkouei <[email protected]>
Signed-off-by: Mahyar Koshkouei <[email protected]>
Enabling unicode causes an issue whereby many folders names with japanese characters are created in the current folder when a game is executed with TotalGB. Odd stuff, so disabling unicode in NFD for now. Signed-off-by: Mahyar Koshkouei <[email protected]>
|
Hi! Thanks for the pr. Unfortunately, all of my emulators have went closed source, which is why there hasn't been any commits pushed in years. I'll leave this open in case anyone wants to build this for windows, however this version of the emulator shouldn't be used. The audio is horrendous, the timers aren't accurate and other edge cases not handled 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I made a few changes to fix building TotalGB on Windows in a MinGW environment (w64devkit). With these changes, compiling with SDL2 support succeeds and I'm able to start playing a game. Tested on Windows 10 only.
Thanks.