Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify packaging #648

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Simplify packaging #648

merged 3 commits into from
Feb 3, 2025

Conversation

oerc0122
Copy link
Collaborator

Description of work
Simplify packaging now we don't have Cython extensions.

Fixes

  • Remove MANIFEST.in
  • Remove setup.py
  • Migrate to pyproject.toml
  • Do not include docs/tests in source distribution.

To test
No change. Standard tests should pass.

@oerc0122 oerc0122 added the styling Any issue related to styling label Jan 30, 2025
@oerc0122 oerc0122 self-assigned this Jan 30, 2025
MBartkowiakSTFC
MBartkowiakSTFC approved these changes Feb 2, 2025
View reviewed changes
Copy link
Collaborator

@MBartkowiakSTFC MBartkowiakSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find any problems with it on my computer.

@oerc0122 oerc0122 merged commit 3a32499 into ISISNeutronMuon:protos Feb 3, 2025
26 checks passed
@oerc0122 oerc0122 deleted the simplify-packaging branch February 3, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBartkowiakSTFC MBartkowiakSTFC MBartkowiakSTFC approved these changes

@ChiCheng45 ChiCheng45 Awaiting requested review from ChiCheng45

Assignees

@oerc0122 oerc0122

Labels
styling Any issue related to styling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oerc0122 @MBartkowiakSTFC