Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes runtime error seen after the GUI is closed when jobs have been terminated. #626

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

ChiCheng45
Copy link
Collaborator

Description of work
Fixes the runtime error seen after the GUI is closed when a job has been terminated.

Fixes
Fixes #502

To test
Run any job in single or multicore mode, the MDANSE Logs text box in the running job tab should update as usual. Run another job, terminate it, and close the GUI. No runtime error should be seen in the console.

Copy link
Collaborator

@MBartkowiakSTFC MBartkowiakSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me a while to reproduce the problem properly, but in the then this PR fixed it as intended. Also, the code has become a bit cleaner as a result. Thanks!

@MBartkowiakSTFC MBartkowiakSTFC merged commit 405b94b into protos Jan 3, 2025
28 checks passed
@MBartkowiakSTFC MBartkowiakSTFC deleted the chi/runtimeerror-on-gui-close-fix branch January 3, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] RuntimeError after GUI close
2 participants