Split trajectory frames into chunks #602
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Trajectory arrays such as positions, velocities and charges are now split into fixed-size chunks within a single time step.
closes #596
Note: the changes in this PR will break the scripts in MDANSE-Examples. The scripts should be updated around the time of the next release.
Fixes
To test
Convert a trajectory using the protos branch. Run Dynamic Coherent/Incoherent Structure Factor analysis on this trajectory and time both runs.
Repeat the same steps using this branch. Compare the results and the timing.
Expected results: DCSF will slow down by ca. 5%, DISF will speed up by ca. 25%, the results should not change.