3d viewer fix when switching trajectories #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MBartkowiakSTFC
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
PR to fix issues with the 3D viewer when switching between trajectories.
Fixes
Fixes #575.
To test
Load up two trajectories with a different number of frames. Switch to the trajectory with the largest number of frames and set the 3d view to its last frame then switch to the other trajectory. The trajectory of the system you switched to should be visible.
Load up two trajectories and set the frame to something other than zero. Switch between the trajectories. The frame in the 3D viewer should not be in the zeroth frame; see #575.