Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the package tags for PyPI and installation instructions #426

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

MBartkowiakSTFC
Copy link
Collaborator

Description of work
The 'topic' tags in pyproject.toml were not correct at the time of the alpha release. Also, minor corrections were needed in the installation instructions.

Fixes

  1. Changed topic tags in pyproject.toml to include Physics and Chemistry,
  2. Corrected the slash characters in Windows installation instructions,
  3. Added the installation instructions for pip install from GitHub,
  4. Added pyqt6-tools to GUI dependencies. This may not be necessary, but it is possible that some installations on Windows machines will not work without it. Also, this fixes the PyQt6 version to a slightly older one.

To test
Please install MDANSE_GUI in a clean virtual environment and see if it starts correctly after installing.

@ChiCheng45 ChiCheng45 self-requested a review April 26, 2024 16:31
Copy link
Collaborator

@ChiCheng45 ChiCheng45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've installed this on a new environment and it loads up without any issues.

@MBartkowiakSTFC MBartkowiakSTFC merged commit c67c54c into protos Apr 29, 2024
84 checks passed
@MBartkowiakSTFC MBartkowiakSTFC deleted the package-description-corrections branch July 9, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants