Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the calculation of formatted time string from Status #413

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

MBartkowiakSTFC
Copy link
Collaborator

Description of work
The calculation of "timedelta" in the Status object causes an occasional random crash with an OverflowError. At the same time, the result of the calculation is not used anywhere.

Note: an individual analysis job should not be spending time calculating its own elapsed time and predicted remaining time. If any process (e.g. GUI) needs this information, they can get the timing information from the Status and do the calculation on their side.

Fixes

  1. The calculation and formatting of the "timedelta" has been removed from the code.
  2. The ._deltas list does not grow indefinitely, and contains only two elements instead. These are [start_time, last_update_time].

To test
Unit tests should pass. Please run a converter job and an analysis job from the GUI to be sure that no side effects have been introduced into the status-gui interaction.

@ChiCheng45
Copy link
Collaborator

Looks good and seems to work as before.

@ChiCheng45 ChiCheng45 merged commit 7a3ea68 into protos Apr 9, 2024
84 checks passed
@MBartkowiakSTFC MBartkowiakSTFC deleted the simplify-time-calculation branch July 9, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants