-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make headers GPL compliant and removed __pkginfo__ #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to ongoing-documentation-update
…x, trr.pyx and xtc.pyx
MBartkowiakSTFC
requested review from
ChiCheng45 and
RastislavTuranyi
and removed request for
RastislavTuranyi
March 27, 2024 13:40
ChiCheng45
changed the title
Make headers GPL compliant
Make headers GPL compliant and removed __pkginfo__
Mar 28, 2024
# Conflicts: # MDANSE/Extensions/qhull.pyx
I've removed copyright and authors from the MDANSE header since they are given in other places and are difficult to maintain. Also removed __pkginfo__ since this information is all specified in the pyproject.yaml. |
# Conflicts: # MDANSE/Src/MDANSE/Framework/Configurators/InputFileConfigurator.py # MDANSE/Src/MDANSE/Framework/Jobs/AreaPerMolecule.py # MDANSE/Src/MDANSE/Framework/Jobs/OrderParameter.py # MDANSE_GUI/Src/MDANSE_GUI/InputWidgets/InputFileWidget.py
ChiCheng45
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
The MDANSE and MDANSE_GUI codes are both licensed under GPLv3. This requires us to use the recommended license notice throughout the code, as per https://www.gnu.org/licenses/gpl-howto.html. Also removed pkginfo files.
Fixes
The headers have been replaced with the GPL-compliant headers. The contents of the copyright notice and authors list are not affected by the change.
To test
There should be no change to the code operation. You are welcome to check if there are still some files that need updating.