Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packaging and github actions updates #393

Merged
merged 14 commits into from
Mar 28, 2024
Merged

Packaging and github actions updates #393

merged 14 commits into from
Mar 28, 2024

Conversation

ChiCheng45
Copy link
Collaborator

@ChiCheng45 ChiCheng45 commented Mar 25, 2024 •
edited
Loading

Description of work
MDANSE and MDANSE_GUI packaging related clean up updates.

  • Updated authors file in the two packages.
  • corrected MANIFEST.in
  • removed requirements.txt since this is defined in the pyproject.yaml
  • removed requirements and changed build install section in github actions
  • removed unused files and old functional tests which no longer work

To test
With a fresh environment try installing MDANSE and MDANSE_GUI using the github generated wheel files and test that the GUI works.

@ChiCheng45
updated the authors in the MDANSE and MDANSE_GUI packages. updated py…
33de8b9 
…project.toml. changed so that dependencies are only in the pyproject file.
@ChiCheng45
fixed and updated manifest.in
4dd3d9a
@ChiCheng45 ChiCheng45 changed the title Packaging updates Packaging and github actions updates Mar 25, 2024
MBartkowiakSTFC
MBartkowiakSTFC approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@MBartkowiakSTFC MBartkowiakSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is a definite improvement.

@MBartkowiakSTFC MBartkowiakSTFC merged commit d46684d into protos Mar 28, 2024
83 of 84 checks passed
@MBartkowiakSTFC MBartkowiakSTFC deleted the package-updates branch March 28, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBartkowiakSTFC MBartkowiakSTFC MBartkowiakSTFC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChiCheng45 @MBartkowiakSTFC