Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Review and Suggestions #242

Merged
merged 12 commits into from
Feb 6, 2024
Merged

Conversation

ashmeigh
Copy link
Collaborator

@ashmeigh ashmeigh commented Nov 13, 2023

This pull request focuses on the comprehensive restructuring and updating of the "mdanse" documentation. The primary objective is to align the documentation with the Diataxis framework, resulting in a more organized, user-friendly, and modular structure.

Changes Made:

Introduction of Diataxis Framework:

Introduced the Diataxis framework, which features the following core sections:
Explanations
Tutorials
How-To Guides
Technical References
Each section serves a distinct purpose and follows a consistent and standardized structure.
Content Migration and Reorganization:

Migrated and meticulously reorganized the existing documentation content into their respective Diataxis sections.
Ensured a seamless transfer of essential information from the old documentation to the new structure, maintaining alignment with the framework.

Essential Content Updates:
Implemented essential updates to the existing content:
Removed outdated GUI (Graphical User Interface) as it's no longer relevant to the project.
Updated all references to Python 3 to ensure compatibility with modern Python versions.
Replaced outdated file format references with "HDF" (Hierarchical Data Format) to reflect contemporary data storage practices.

Expected Benefits:

Improved documentation organization for streamlined access to explanations, tutorials, how-to guides, and technical references.
Alignment with contemporary software practices, ensuring compatibility with modern Python and data storage standards.
Enhanced clarity, relevance, and usability of the documentation.

Checklist:

Documentation structure and content have been successfully updated.
Tutorials have been planned and created.
How-to guides have been fully created.
Essential changes to explanations have been implemented.
The new "Technical References" section has been introduced.

@MBartkowiakSTFC
Copy link
Collaborator

@ashmeigh What output did you get when you built the documentation? It seems that quite a few errors and warnings are still triggered when I build it on my computer.

documentation_build_output.txt

Using MDANSE Graphical User Interface
.. _section-7:

Section 7: Navigating the MDANSE GUI
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely don't put any numbers in the title of a section. It's up to the documentation engine to assign numbers. Now if you move this text segment, the number will be wrong.

analysis parameters, and visualizing results. This section provides an
overview of how to effectively utilize the MDANSE GUI.

7.1. Key Actions in the MDANSE GUI
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same problem here: the number should not be included in the text.

@@ -1,16 +1,333 @@

Using MDANSE Graphical User Interface
.. _section-7:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This label should, if possible, refer to the contents of the text and not number of the section.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file name contains a space, and in a very awkward location, directly before the extension. Please rename.

Below is an image of the main MDANSE GUI window with annotated
descriptions of its key components:

1. File Menu: Handles file manipulation, including loading HDF trajectories
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of list really should use automatic numbering.

@@ -131,7 +127,7 @@ information.
MDANSE started as a fork of [version 3 of the nMOLDYN program](https://github.com/khinsen/nMOLDYN3).
nMOLDYN was originally developed by Gerald Kneller in 1995 and subsequently also by Konrad Hinsen, Tomasz Rog,
Krzysztof Murzyn, Slawomir Stachura, and Eric Pellegrini. MDANSE includes most of the code of nMOLDYN3, and also code
from the libraries [MMTK](https://github.com/khinsen/MMTK) and [ScientificPython](https://github.com/khinsen/ScientificPython),
from the libraries [](https://github.com/khinsen/) and [ScientificPython](https://github.com/khinsen/ScientificPython),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was clearly NOT meant to happen. The MMTK name has to stay here, as this is the explanation of the origins of MDANSE.

@MBartkowiakSTFC
Copy link
Collaborator

MBartkowiakSTFC commented Jan 19, 2024

Closes #10 #11

Copy link
Collaborator

@MBartkowiakSTFC MBartkowiakSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes! The structure of the documentation is much better now.

@MBartkowiakSTFC MBartkowiakSTFC merged commit 1574364 into protos Feb 6, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants