-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First tutorial #5
Conversation
## Background | ||
|
||
Most of the commonly taught thermodynamics and mechanical | ||
statistics deals with equilibrium processes. That is, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
statistical mechanics?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I knew this paragraph looked strange.
I've been going through the tutorial and everything seems to work and I think the content is great for the first tutorial. I just had a thought that we should probably create a GitHub action and get it to pull and build the latest MDANSE and run those scripts and check the file exists etc. That will ensure the tutorial and MDANSE keeps working. We can make the action run nightly or something. I've created #6 for this suggestion. |
will be significantly different to the other points. This | ||
is to be expected, since interpolation will not be accurate | ||
when there are no values to interpolate between on one side | ||
of the data point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to be expected since interpolation will not be accurate when values are only available on one side of its data point.
(change above - should be a bit clearer I think)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, looks good!
This is the first tutorial for the new MDANSE version.
The PR includes some basic cleaning up of the repository, moving test files around.
Is the structure of the tutorial good?
Is the level of detail sufficient?
Finally, is there anything in the text that is just wrong?
Comment: we may need also a tutorial 0: installing MDANSE.