fix: handle reconnect get_modifiers #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After updating the firmware on my PPK2 to v4.2.0 I noticed that connecting, disconnected then trying to reconnect failed. It seems like the updated firmware has some 0x80 byte that gets send and as a result an exception gets thrown. This commit allows those bytes to be replaced, thus the check is still valid but we do not get this exception.
MrKevinWeiss
changed the title
|
Could you explain a bit more of how you're using the API? Running |
|
Ahh sorry for the delayed response, last week was pretty busy. Unfortunately I cannot open-source it (yet), but I essentially call Like I said, this only occurred when updating the PPK firmware and was not a problem before. Here is a simplified script: from ppk2_api.ppk2_api import PPK2_API
ppk = PPK2_API("/dev/ttyACM0", timeout=1, write_timeout=1, exclusive=True)
ppk.get_modifiers()
ppk.set_source_voltage(int(3.6 * 1000))
ppk.toggle_DUT_power("ON")
ppk.use_source_meter()
ppk.start_measuring()
import time
time.sleep(0.1)
print(len(ppk.get_data()))
ppk.stop_measuring()
ppk.toggle_DUT_power("OFF")When running the first time it works, the second and third time it fails, then it works again and the pattern repeats Currently I am just patching the like so: class myPPKWrapper():
def __init__(self):
...
self._ppk = PPK2_API(self.ppk_port, timeout=1, write_timeout=1, exclusive=True)
self._ppk._read_metadata = self._patched_ppk_read_metadata
def _patched_ppk_read_metadata(self):
"""This is a fix since the upstream has a bug
The issue is that the updated firmware on the PPK sends a 0x81 byte
and since the decoding is strict, an exception is raised... We can
just replace it and it seems to work okay.
"""
# try to get metadata from device
for _ in range(0, 5):
# it appears the second reading is the metadata
read = self._ppk.ser.read(self._ppk.ser.in_waiting)
sleep(0.1)
# TODO add a read_until serial read function with a timeout
if read != b"" and "END" in read.decode("utf-8", errors="replace"):
return read.decode("utf-8", errors="replace") |
|
More info... Here is the actual thing that is read from the serial port: Just for some info, I would assume that the parse_metadata function cannot handle the leading garbage for the |
|
With the same ppk2_api version (0.9.2), I'm seeing a similar problem: I sporadically see different Are you sure that the problem you are seeing is always at the same position, or is it maybe happening at some random position as in my case? Also, I fear that the change proposed in this PR will only hide an existing bug. Is it possible, that the PPK2 is sporadically returning nonsense? |
|
Ya, it is not that clear. For now we can say there is a bug in there but this probably isn't the best fix. It somehow works for me but probably this shouldn't be merged in without further investigation... I will try to find some time to dig into it but cannot make promises. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating the firmware on my PPK2 to v4.2.0 I noticed that connecting, disconnected then trying to reconnect failed. It seems like the updated firmware has some
0x81byte that gets send and as a result an exception gets thrown.This commit allows those bytes to be replaced, thus the check is still valid but we do not get this exception.
This was discovered with the following version:
Error Traceback