switch container demo tutorial from FAKE to perma #11108
Merged
+14
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
added
Size: 3
|
Looks reasonable to me. Will request a look from Jim |
|
followed instructions, no issues found. Persistent Identifier generated for all new datasets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The Permalink PID provider is well suited to dev, devo, and evaluation environments. Partially inspired by a question about how to set it up, we decided to go ahead and update the compose.yml file used in our demo/eval tutorial (6.5 version) to use Permalinks instead of the FAKE DOI provider.
Which issue(s) this PR closes:
Special notes for your reviewer:
As I mentioned in Slack, I still think the docs are a bit off but I didn't want to muddy the waters too much in this PR.
Suggestions on how to test this:
Follow the tutorial. Make sure a dataset is properly indexed.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No, but as shown in the screenshot below, PIDs look something like this: perma:DV/ADTGQL
In the citation, the URL form is shown, like this: http://localhost:8080/citation?persistentId=perma:DV/ADTGQL
Is there a release notes update needed for this change?:
Yes, added.
Additional documentation:
Preview at https://dataverse-guide--11108.org.readthedocs.build/en/11108/container/running/demo.html