-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dirty-waters workflow to CI #6182
base: master
Are you sure you want to change the base?
Conversation
Skipping tests first time is necessary for me because I want to build the agent to run the tests. But if run the tests straightaway, the agent does not exist so tests fail and I also don't get the built agent. |
the current value, we should never go higher than this.
false
If the comment it only in case of CI failure yes, else no.
no, not needed for this MVP
full reporting. thanks @randomicecube |
It currently isn't, but I'll make it so Thanks for the feedback, I'll ping again when everything is done |
I also want to note that I will not merge any per-commit/PR workflow that takes longer than ~10 Minutes (ideally much shorter). The CI already takes ages to run, I don't want to wait 40 minutes for a result. |
@I-Al-Istannen Absolutely, there's a bug which I'm working on fixing right now which is making it so that the cache isn't being stored with the correct key -- I'll fix it, test it, link the test results (and run them here too) |
From my tests in the fork I have, this doesn't work yet either with v1.8, so no need to accept the workflow just yet EDIT: Ok you were right, it's due to caching inheritance! Because, for example, in this commit in a main branch, the cache is correctly stored; furthermore, in this PR, the action is triggered both by push and by PR: the push one stores correctly, the PR one doesn't! |
as per #2, should be working now
cc @monperrus @Stamp9
Relates to #5216, chains-project/dirty-waters#37, chains-project/dirty-waters#58
Key notes:
x_to_fail
parameter: the percentage of a single non-high severity issue present among the dependencies for the CI to break. It defaults to 5%, so what should it be here?comment_on_commit
: whether the reports are allowed to be pasted as comments in the commits, in the case of high-severity issues breaking CI. Defaults to false, what do we want here?allow_pr_comments
: whether the reports are allowed to be pasted as comments in pull requests. Defaults to true, what do we want here?For more information on the action, see the wiki.