Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create test_generalized_fish_game.py writing tests using pytest for generalized_fish_game.py file #108
base: dev
Are you sure you want to change the base?
Create test_generalized_fish_game.py writing tests using pytest for generalized_fish_game.py file #108
Changes from 4 commits
3fd0411
f04dd34
47547b5
c1f3b7d
c13eb4c
1562e91
882eb87
6339dec
a303af2
e355732
2ec7f51
fc12675
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is duplicating exactly what the function does, it's not an effective test. You should hardcode this value instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a hardcoded value. Since we're trying to determine if the function is producing incorrect outputs, and we know what the output should be given certain inputs, we should check for that output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also check for a hardcoded value. Since we're trying to determine if the function is producing incorrect outputs, and we know what the output should be given certain inputs, we should check for that output.