test_fishery_dynamics.py creating test file using pytest for fishery_dynamics.py file #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erexer
reviewed
Aug 19, 2024
Fixing corrected imports, import from msdbook getting the fishery_dynamics module, to ensure that the fishery_dynamics.py file is indeed in the msdbook package directory. Fixing the color bars, checking color bars in matpoltib used plt.colorbar replaced fig.colorbar.
erexer
reviewed
Aug 27, 2024
Removed the comment next to the import message. Should fix the error module 'matplotlib.pyplot' has no attribute 'Colorbar'.
erexer
changed the title
…uncertainty_ebook into Jaydon2005-patch-1
… deprecated get_cmap method
erexer
requested changes
Oct 17, 2024
…rning while running the plotting functions.
…cm.get_cmap("RdBu_r") with plt.colormaps["Blues"] and plt.colormaps["RdBu_r"]
…ery_dynamics.py creating test file using pytest for fishery_dynamics.py file
|
converted to draft since checks are failing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #107 +/- ##
==========================================
+ Coverage 2.07% 45.49% +43.41%
==========================================
Files 9 11 +2
Lines 529 633 +104
==========================================
+ Hits 11 288 +277
+ Misses 518 345 -173 ☔ View full report in Codecov by Sentry. |
Thank you, Travis! I will merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Branch is branching off of the dev branch testing the fishery dynamics file using pytest , changed from fishery_dynamics to from msdbook.fishery_dynamics and has pyproject.toml with mock & pytest. Added from matplotlib.colorbar import colorbar