Add two criteria based direct llm judges #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lilacheden <[email protected]>
yoavkatz
reviewed
Jan 21, 2025
| "option_map": option_map, | ||
| } | ||
| ) | ||
|
|
There was a problem hiding this comment.
Criteria should be added here as catalog entries:
https://www.unitxt.ai/en/latest/catalog/catalog.metrics.llm_as_judge.direct.criterias.__dir__.html
There was a problem hiding this comment.
@yoavkatz - ok, added the criteria to the catalog
Signed-off-by: lilacheden <[email protected]>
yoavkatz
reviewed
Jan 21, 2025
| ) | ||
| add_to_catalog( | ||
| adherence_metric, | ||
| f"metrics.llm_as_judge.direct.criteria_judges.llama_3_3_70b_instruct_{adherence_criteria.name}", |
There was a problem hiding this comment.
Since these metrics require specific fields (e.g. "question" or "reference_answer"). I think it will be simpler for the users to understand when to use them, by they are under the task "metrics.rag.response_generation.adherence.llama_3_3_70b_instruct_judge"
Signed-off-by: lilacheden <[email protected]>
yoavkatz
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.