[WiP] Sen4Map inheritance class change to geobench-compatible datamodule and dataset classes #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssification update Signed-off-by: hashim1 <[email protected]>
Signed-off-by: hashim1 <[email protected]>
…ions from eli Signed-off-by: hashim1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue first raised in #226, Sen4map dataclass and datamodule classes currently only inherit from pytorch lightning, which is functionally adequate for terratorch but will not work with benchmark. I have updated the datamodule class to inherit from NonGeoDataModule, which required a few extra changes.
To get the Sen4map datamodule class to work with inheritance from NonGeoDataModule I had to define a custom augmentation
self.aug = AugmentationSequential(K.RandomEqualize3D(), data_keys=None), is this okay? What is the default augmentation and why does it only (seemingly) work for BCHW tensors and not BCDHW tensors?