Skip to content

Commit

Permalink
Merge pull request #23 from IBM/public_cert
Browse files Browse the repository at this point in the history
  • Loading branch information
IdanAdar authored Sep 19, 2021
2 parents ad37382 + 61c6bb5 commit 0b8501d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@ jobs:
SECRETS_MANAGER_API_AUTH_TYPE: iam
SECRETS_MANAGER_API_APIKEY: ${{ secrets.SECRETS_MANAGER_API_APIKEY }}
SERVICE_URL: https://9476d663-dc80-4132-aff6-4585ebbdfb2d.us-south.secrets-manager.appdomain.cloud
DNS_CONFIG_CRN: crn:v1:staging:public:internet-svcs-ci:global:a/791f5fb10986423e97aa8512f18b7e65:dc08a28a-9181-45db-bf0d-a8733a5796b6::
DNS_CONFIG_CRN: "crn:v1:staging:public:internet-svcs-ci:global:a/791f5fb10986423e97aa8512f18b7e65:dc08a28a-9181-45db-bf0d-a8733a5796b6::"
CA_CONFIG_PRIVATE_KEY: ${{ secrets.CA_CONFIG_PRIVATE_KEY }}

DNS_CONFIG_API_KEY: ${{ secrets.DNS_CONFIG_API_KEY }}
4 changes: 2 additions & 2 deletions secretsmanagerv1/secrets_manager_v1_integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ var _ = Describe(`IbmCloudSecretsManagerApiV1_integration`, func() {

cisConfig := secretsmanagerv1.ConfigElementDefConfigCloudInternetServicesConfig{
CisCRN: core.StringPtr(os.Getenv("DNS_CONFIG_CRN")),
CisApikey: core.StringPtr(os.Getenv("SECRETS_MANAGER_API_APIKEY")),
CisApikey: core.StringPtr(os.Getenv("DNS_CONFIG_API_KEY")),
}
_, resp, err = secretsManager.CreateConfigElement(&secretsmanagerv1.CreateConfigElementOptions{
SecretType: core.StringPtr(secretsmanagerv1.CreateConfigElementOptionsSecretTypePublicCertConst),
Expand Down Expand Up @@ -450,7 +450,7 @@ var _ = Describe(`IbmCloudSecretsManagerApiV1_integration`, func() {

cisConfig := secretsmanagerv1.ConfigElementDefConfigCloudInternetServicesConfig{
CisCRN: core.StringPtr(os.Getenv("DNS_CONFIG_CRN")),
CisApikey: core.StringPtr(os.Getenv("SECRETS_MANAGER_API_APIKEY")),
CisApikey: core.StringPtr(os.Getenv("DNS_CONFIG_API_KEY")),
}
_, resp, err = secretsManager.CreateConfigElement(&secretsmanagerv1.CreateConfigElementOptions{
SecretType: core.StringPtr(secretsmanagerv1.CreateConfigElementOptionsSecretTypePublicCertConst),
Expand Down

0 comments on commit 0b8501d

Please sign in to comment.