Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: track logical paths in recursive validation functions #709

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

hudlow
Copy link
Member

@hudlow hudlow commented Dec 23, 2024

PR summary

PR Checklist

General checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Dependencies have been updated as needed
  • .secrets.baseline has been updated as needed
  • npm run generate-utilities-docs has been run if any files in packages/utilities/src have been updated

@hudlow
Copy link
Member Author

hudlow commented Dec 23, 2024

Still missing explicit tests for:

  • the SchemaPath class
  • this guarantee of validateSubschemas():
    The provided `validate()` function is guaranteed to be called:
    - for a schema before any of its composed schemas
    - for a schema before any of its nested schemas
    
  • The clarification noted in this comment

Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor formatting comments. Tests are looking good!

packages/utilities/src/utils/schema-path.js Outdated Show resolved Hide resolved
packages/utilities/test/schema-path.test.js Outdated Show resolved Hide resolved
@hudlow hudlow force-pushed the hudlow/logical-paths branch from 83b2db5 to 483c2d8 Compare January 3, 2025 19:48
@hudlow hudlow marked this pull request as ready for review January 3, 2025 19:53
@hudlow hudlow force-pushed the hudlow/logical-paths branch from 5b2adb0 to 0535cd3 Compare January 3, 2025 19:54
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@hudlow hudlow force-pushed the hudlow/logical-paths branch from 6ee8193 to 731536a Compare January 7, 2025 22:21
@hudlow hudlow merged commit b1f2fbf into main Jan 7, 2025
7 checks passed
@hudlow hudlow deleted the hudlow/logical-paths branch January 7, 2025 22:26
ibm-devx-sdk pushed a commit that referenced this pull request Jan 7, 2025
# @ibm-cloud/openapi-ruleset-utilities [1.7.0](https://github.com/IBM/openapi-validator/compare/@ibm-cloud/[email protected]...@ibm-cloud/[email protected]) (2025-01-07)

### Features

* track logical paths in recursive validation functions ([#709](#709)) ([b1f2fbf](b1f2fbf))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 1.7.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@ibm-devx-sdk
Copy link

🎉 This PR is included in version 1.27.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@ibm-devx-sdk
Copy link

🎉 This PR is included in version 1.31.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants