Feature csi 5536 add fence implementation #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ArbelNathan <[email protected]>
…feature/CSI-5536_fence_design_tests # Conflicts: # controllers/scripts/csi_general/csi_pb2.sh # controllers/servers/csi/controller_server_manager.py
Signed-off-by: ArbelNathan <[email protected]>
Signed-off-by: ArbelNathan <[email protected]>
Signed-off-by: ArbelNathan <[email protected]>
Signed-off-by: ArbelNathan <[email protected]>
…dentity_servicer' into feature/CSI-5536_fence_design_tests # Conflicts: # controllers/array_action/array_mediator_svc.py
Signed-off-by: arbenathan <[email protected]>
Signed-off-by: arbenathan <[email protected]>
matancarmeli7
approved these changes
Jun 29, 2023
Comment on lines
+2093
to
+2105
| hosts = self.client.svcinfo.lshost(filtervalue=filter_value).as_list | ||
| host_names = [host.name for host in hosts] | ||
|
|
||
| volumes = self._lsvdisk_list(filtervalue=filter_value) | ||
| volume_names = [volume.name for volume in volumes] | ||
|
|
||
| mappings = self.client.svcinfo.lshostvdiskmap().as_list | ||
|
|
||
| relevant_mappings = [mapping for mapping in mappings if | ||
| mapping.name in host_names and mapping.vdisk_name in volume_names] | ||
| logger.info(svc_messages.REMOVING_MAPPINGS.format(relevant_mappings)) | ||
| for mapping in relevant_mappings: | ||
| self.client.svctask.rmvdiskhostmap(vdisk_name=mapping.vdisk_name, host=mapping.name) |
There was a problem hiding this comment.
you can export this code into some functions, it can make it more cleaner IMO, but it's not important, it's not a blocker for the PR
leonid-s-usov
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.