Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Recompute def embs between epochs during training #94

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jasonrute
Copy link
Contributor

This isn't ready to merge yet. I'm making this PR, so others can comment on this approach.

This PR makes it possible to recompute definitions between epochs.

  • Pass the data_server directly to the training class
  • Use a callback containing a pointer to the data_server to loop over all definitions.
  • Copied code from the tfgnn predict code needed to compute definition embeddings

TODO:

  • Do full training run with benchmark to see if added complexity is worth it.
  • Decide best way to access definition clusters during training. Currently I'm passing a pointer to the data server to the Keras callback.
  • Combine large amounts of duplicated code with the tfgnn predict code into one unified place.

@jasonrute jasonrute force-pushed the jrute/recompute-defs-training branch from 37277bc to 20733ee Compare February 1, 2023 01:40
Jason Rute added 4 commits February 1, 2023 19:21
@jasonrute jasonrute force-pushed the jrute/recompute-defs-training branch from 20733ee to cfb69b8 Compare February 2, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant