Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hf data access #962

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

Hf data access #962

wants to merge 12 commits into from

Conversation

blublinsky
Copy link
Collaborator

@blublinsky blublinsky commented Jan 23, 2025

Why are these changes needed?

AI Alliance is planning to use Data Prep Kit for validating data stored in HF datasets

Related issue number (if any).

#964

@touma-I touma-I self-requested a review January 23, 2025 13:11
Copy link
Collaborator

@touma-I touma-I left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plese create an issue describing in details the problem you are trying to solve and provide outline of the sollution, solicit peer input before submitting a PR.

@deanwampler
Copy link
Contributor

deanwampler commented Jan 23, 2025

Plese create an issue describing in details the problem you are trying to solve and provide outline of the sollution, solicit peer input before submitting a PR.

Creating an issue is fine; lots of projects like requiring one for PRs. However, telling the user to "solicit peer input before submitting a PR" will just discourage people from submitting PRs. If you want to suggest that users "float a crazy idea" first, okay, but most people will just walk away if you expect this engagement. They are doing you a service by offering improvements.

Concerning this PR, integration with the HF dataset API is mandatory for DPK to be useful for OTDI, so please take this seriously.

@touma-I
Copy link
Collaborator

touma-I commented Jan 23, 2025

Plese create an issue describing in details the problem you are trying to solve and provide outline of the sollution, solicit peer input before submitting a PR.

Creating an issue is fine; lots of projects like requiring one for PRs. However, telling the user to "solicit peer input before submitting a PR" will just discourage people from submitting PRs. If you want to suggest that users "float a crazy idea" first, okay, but most people will just walk away if you expect this engagement. They are doing you a service by offering improvements.

Concerning this PR, integration with the HF dataset API is mandatory for DPK to be useful for OTDI, so please take this seriously.

@deanwampler thanks for the feedback. Peer review will allow us to determine if the propose enhancement will indeed improve the overall framework and therefore adoption. I don't know if this falls into the "crazy idea" you are talking about and will take a look at the issue once you have created one. Please be detailed in describing what you are trying to achieve and discuss in details the alternatives to reach your goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants