Remove KFP_DOCKER_VERSION. #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revit13
requested review from
touma-I and
roytman
and removed request for
touma-I
touma-I
reviewed
Jan 15, 2025
There was a problem hiding this comment.
@revit13 You need to merge from dev first as lines 39 and 40 were changed by the previous PR. Which may be why you have a conflict.
touma-I
reviewed
Jan 15, 2025
Signed-off-by: Revital Sur <[email protected]>
Fixed Thanks |
touma-I
approved these changes
Jan 16, 2025
touma-I
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Remove KFP_DOCKER_VERSION and use DOCKER_IMAGE_VERSION instead