Update KFP_DOCKER_VERSION. #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Revital Sur <[email protected]>
touma-I
reviewed
Jan 14, 2025
There was a problem hiding this comment.
@revit13 @roytman Should we get rid of KFP_DOCKER_VERSION completely ? The only place I see it being used is here
and it is only to assign back to DOCKER_IMAGE_VERSION.echo "Publishing kfp-data-processing"
$(MAKE) KFPv2=0 DOCKER_IMAGE_NAME="kfp-data-processing" DOCKER_IMAGE_VERSION=${KFP_DOCKER_VERSION} .defaults.publish-image
echo "Publishing kfp-data-processing_v2"
$(MAKE) KFPv2=1 DOCKER_IMAGE_NAME="kfp-data-processing_v2" DOCKER_IMAGE_VERSION=${KFP_DOCKER_VERSION_v2} .defaults.publish-image
There was a problem hiding this comment.
Sounds good to me. Thanks
touma-I
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
KFP docker image is pushed with 0.2.3 tag where the latest tag is used for building the image which results in an error while publishing the image.
This can be seen in here:
https://github.com/IBM/data-prep-kit/actions/runs/12742690556/job/35519698253
Related issue number (if any).
#936