Refactoring code profiler transform to new pythonic code layout #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajskku
force-pushed
the
dev
branch
6 times, most recently
from
170c757 to
8d01d2f
Compare
Signed-off-by: Pankaj Thorat <[email protected]>
pankajskku
added a commit
to pankajskku/data-prep-kit
that referenced
this pull request
Jan 6, 2025
Signed-off-by: Pankaj Thorat <[email protected]>
touma-I
added a commit
that referenced
this pull request
Jan 8, 2025
Refactoring code profiler transform to new pythonic code layout #913
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Refactoring code profiler transforms to new pythonic code layout to fix file path issue in the DPK package.
Issue Description
While working with the .whl distribution of the dpk_code_profiler_transform_python package (version 0.2.3.dev0), I noticed that certain .csv files required by the code are missing from the installed package. Specifically, the following file paths could not be resolved:
semantic-ruleset/ikb_model.csv
semantic-ruleset/null_libs.csv
When attempting to run the code, it fails with a FileNotFoundError because these files are not included in the wheel distribution.
Impact
The missing .csv files are essential for the proper functioning of the transform. Without them, the code cannot execute as intended, resulting in runtime errors.
Possible Cause
It seems that while these files are present in the source code, they are not being included in the .whl file during the packaging process. Locally I verified and these csv files are present in the files dpk_code_profiler_transform_ray-0.2.3.dev0.tar.gz and the dpk_code_profiler_transform_ray-0.2.3.dev0-py3-none-any.whl files created in dist folder after make build.
When I installed the packages for these transforms to use the DPK-inner venv, a folder named semantic-ruleset was created, but it does not contain the .csv files. To address this issue, I suggest ensuring that the .csv files are explicitly included in the wheel distribution.
Related issue number (if any).