Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tolerations and node selector to KFP pods #643

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Conversation

revit13
Copy link
Collaborator

@revit13 revit13 commented Sep 30, 2024

Why are these changes needed?

Add Tolerations and node selector to KFP pods

To apply kuberenetes Tolerations or nodeSelector to KFP pods, you need to set KFP_TOLERATIONS or KFP_NODE_SELECTOR environment variables respectively before compiling the pipeline. Here's an example:

export KFP_TOLERATIONS='[{"key": "key","operator": "Equal", "value1": "value", "effect": "NoSchedule"}]'

export KFP_NODE_SELECTOR='{"label_key":"cloud.google.com/gke-accelerator","label_value":"nvidia-tesla-p4"}'

Related issue number (if any).

Relates to #620

@revit13 revit13 requested a review from roytman September 30, 2024 06:05
@roytman
Copy link
Member

roytman commented Sep 30, 2024

Can you please combine Tolerance settings with PR #627 , so users will not have to update several parts.

@revit13 revit13 force-pushed the kfp_taint branch 3 times, most recently from cb4cb9e to 400a016 Compare October 1, 2024 06:50
@revit13
Copy link
Collaborator Author

revit13 commented Oct 1, 2024

Can you please combine Tolerance settings with PR #627 , so users will not have to update several parts.

Done for kfp v1, I'll open an issue as you request for kfp v2.

Copy link
Member

@roytman roytman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Revital Sur <[email protected]>
Signed-off-by: Revital Sur <[email protected]>
Signed-off-by: Revital Sur <[email protected]>
Signed-off-by: Revital Sur <[email protected]>
@roytman roytman merged commit afc4150 into IBM:dev Oct 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants