Skip to content

Commit

Permalink
chasing after DOCKER_REMOTE_IMAGE
Browse files Browse the repository at this point in the history
Signed-off-by: Maroun Touma <[email protected]>
  • Loading branch information
touma-I committed Nov 17, 2024
1 parent 6631851 commit 1c58a5c
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
8 changes: 4 additions & 4 deletions transforms/.make.cicd.targets
Original file line number Diff line number Diff line change
Expand Up @@ -120,25 +120,25 @@ kind-load-image:: .transforms.kind-load-image
.PHONY: workflow-vent
workflow-venv:
if [ -e kfp_ray ]; then \
$(MAKE) -C kfp_ray workflow-venv; \
$(MAKE) -C kfp_ray TRANSFORM_NAME=$(TRANSFORM_NAME) workflow-venv; \
fi

.PHONY: workflow-test
workflow-test:
if [ -e kfp_ray ]; then \
$(MAKE) -C kfp_ray workflow-test; \
$(MAKE) -C kfp_ray TRANSFORM_NAME=$(TRANSFORM_NAME) workflow-test; \
fi

.PHONY: workflow-upload
workflow-upload:
if [ -e kfp_ray ]; then \
$(MAKE) -C kfp_ray workflow-upload; \
$(MAKE) -C kfp_ray TRANSFORM_NAME=$(TRANSFORM_NAME) workflow-upload; \
fi

.PHONY: workflow-build
workflow-build:
if [ -e kfp_ray ]; then \
$(MAKE) -C kfp_ray workflow-build; \
$(MAKE) -C kfp_ray TRANSFORM_NAME=$(TRANSFORM_NAME) workflow-build; \
fi


1 change: 0 additions & 1 deletion transforms/.make.workflows
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ FORCE:
cd ${REPOROOT} && make -C scripts/k8s-setup setup; \
fi
ifeq ($(USE_DEV_IMAGES), 1)
echo ******###**** $(DOCKER_REMOTE_IMAGE)
cd ${TRANSFORM_SRC} && $(MAKE) image && $(MAKE) kind-load-image
cd ${REPOROOT}/kfp/kfp_ray_components && $(MAKE) image && $(MAKE) kind-load-image
endif
Expand Down
3 changes: 3 additions & 0 deletions transforms/language/html2parquet/kfp_ray/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ workflow-build: workflow-venv
.PHONY: workflow-test
workflow-test: workflow-build
$(MAKE) TRANSFORM_SRC=${SRC_DIR} \
TRANSFORM_RUNTIME=$(TRANSFORM_RUNTIME) \
TRANSFORM_NAME=$(TRANSFORM_NAME) \
BUILD_SPECIFIC_RUNTIME=$(BUILD_SPECIFIC_RUNTIME) \
DOCKER_REMOTE_IMAGE=$(DOCKER_REGISTRY_ENDPOINT)/$(DOCKER_IMAGE_NAME):$(DOCKER_IMAGE_VERSION) \
PIPELINE_FILE=html2parquet_wf.yaml .workflows.test-pipeline

Expand Down

0 comments on commit 1c58a5c

Please sign in to comment.