fix: assert checks and task status for idempotent #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riable checks to main.yml, remove message with string sample-sap-monitoring-parameters.yml, show ansible results as 'OK' not 'changed' executing port checks and sap-hana-keystore checks, converting string to integer in template templates/sap_host_exporter-DI.conf.j2 to prevent typecast error
|
pre-commit passed, |
surajsbharadwaj
requested changes
Jan 3, 2025
There was a problem hiding this comment.
Please see comments for each file @AchimHaaser1
Also please keep it consistent for all integer types:
Ansible will automatically try to infer the type of the variable based on its content. For example:
If you provide a value like "42", Ansible will treat it as a string, but you can convert it to an integer using | int.
surajsbharadwaj
changed the title
… when-statement. Warning: Collection community.general does not support Ansible version 2.14.14.
…check status of hana-keytore to changed , renamed assertion titles, removed paranthesis of asserted variables
surajsbharadwaj
requested changes
Jan 4, 2025
surajsbharadwaj
requested changes
Jan 7, 2025
… schematics. Changes on the READMEs.
…md starts, adapt tasks, templates sap_host_exporter-DI.conf.j2 and prometheus-sap_monitoring_nr.j2
surajsbharadwaj
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…riable checks to main.yml, remove message with string sample-sap-monitoring-parameters.yml, show ansible results as 'OK' not 'changed' executing port checks and sap-hana-keystore checks, converting string to integer in template templates/sap_host_exporter-DI.conf.j2 to prevent typecast error