Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nfs client check, updated RFS #70

Merged
merged 12 commits into from
Dec 10, 2024
Merged

fix: nfs client check, updated RFS #70

merged 12 commits into from
Dec 10, 2024

Conversation

stafaniasaju
Copy link
Collaborator

  • RFS changes reimplemented
  • bug fix for NFS client check. Now checks explicitly on RHEL and SLES

Copy link
Collaborator

@surajsbharadwaj surajsbharadwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make the following changes ?

  1. Include prefix for sap_hana_preconfigure, sap_netweaver_preconfigure, sap_general_preconfigure ::::

should be redhat.sap_install.sap_general_preconfigure
....
.



2. Remove #no-fcqdn [name]. For lvg, vgs etc use community.general (sync with @ludwig)
3. RFS :
1. - name: Update rps_sock_flow_entries runtime value ?? Why should this be performed when reloading it later ?
2. Create custom systemd unit for RFS configuration ? Should happen if it doesn’t exit. Idempotent must be respected

@stafaniasaju
Copy link
Collaborator Author

stafaniasaju commented Dec 3, 2024

Can you please make the following changes ?

  1. Include prefix for sap_hana_preconfigure, sap_netweaver_preconfigure, sap_general_preconfigure ::::

should be redhat.sap_install.sap_general_preconfigure .... .


  1. Remove #no-fcqdn [name]. For lvg, vgs etc use community.general (sync with @ludwig)
  2. RFS :
    • name: Update rps_sock_flow_entries runtime value ?? Why should this be performed when reloading it later ?
  3. Create custom systemd unit for RFS configuration ? Should happen if it doesn’t exit. Idempotent must be respected

The rfs-config.service is a custom service, not a standard one. It is explicitly defined in the playbook to handle a specialized task: dynamically configuring rps_flow_cnt for network interface queues, which cannot be directly persisted via traditional mechanisms like sysctl. After considering few options to modify sysfs file, I think using a systemd service is a good option to persist changes.
Necessary changes implemented for all other comments.
Will resolve the pipeline run failure with Sahitya.

@surajsbharadwaj surajsbharadwaj merged commit 0df542c into main Dec 10, 2024
0 of 3 checks passed
@surajsbharadwaj surajsbharadwaj deleted the item_312_v2 branch December 10, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants