-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: nfs client check, updated RFS #70
Conversation
stafaniasaju
commented
Dec 2, 2024
- RFS changes reimplemented
- bug fix for NFS client check. Now checks explicitly on RHEL and SLES
0e58bb4
to
8e522b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please make the following changes ?
- Include prefix for sap_hana_preconfigure, sap_netweaver_preconfigure, sap_general_preconfigure ::::
should be redhat.sap_install.sap_general_preconfigure
....
.
name: sap_hana_preconfigure |
2. Remove #no-fcqdn [name]. For lvg, vgs etc use community.general (sync with @ludwig)
3. RFS :
1. - name: Update rps_sock_flow_entries runtime value ?? Why should this be performed when reloading it later ?
2. Create custom systemd unit for RFS configuration ? Should happen if it doesn’t exit. Idempotent must be respected
Signed-off-by: stafaniasaju <[email protected]>
Signed-off-by: stafaniasaju <[email protected]>
Signed-off-by: stafaniasaju <[email protected]>
849f496
to
3fb7966
Compare
The rfs-config.service is a custom service, not a standard one. It is explicitly defined in the playbook to handle a specialized task: dynamically configuring rps_flow_cnt for network interface queues, which cannot be directly persisted via traditional mechanisms like sysctl. After considering few options to modify sysfs file, I think using a systemd service is a good option to persist changes. |