Skip to content

Commit

Permalink
fix: upgrade minimum community general version to 10.1.0 (#72)
Browse files Browse the repository at this point in the history
  • Loading branch information
surajsbharadwaj authored Dec 11, 2024
1 parent c9316e1 commit 8030c5d
Show file tree
Hide file tree
Showing 13 changed files with 49 additions and 35 deletions.
20 changes: 19 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,28 @@
# Release Notes

<a name="v3.1.1"></a>
# [v3.1.1](https://github.com/IBM/ansible-power-linux-sap/releases/tag/v3.1.1) - 11 Dec 2024

## Release Summary
* fix: Requires community.general version 10.1.0 to use community.general.filesystem


<a name="v3.1.0"></a>
# [v3.1.0](https://github.com/IBM/ansible-power-linux-sap/releases/tag/v3.1.0) - 05 Dec 2024

## Release Summary
* fix: Checks for NFS client on RHEL
* fix: RFS settings on RHEL and SLES

<a name="v3.0.0"></a>
# [v3.0.0](https://github.com/IBM/ansible-power-linux-sap/releases/tag/v3.0.0) - 05 Nov 2024

## Release Summary
* Breaking changes: Previous roles powervs_prepare_rhel_sap and powervs_prepare_sles_sap are now powervs_os_registration and powervs_configure_os_for_sap
Previous roles powervs_storage_setup and powervs_swap_creation now combined to one role powervs_storage_and_swap_setup
Previous roles powervs_client_enable_services and powervs_install_services now combined to one role configure_network_management_services
Please take a look at the READMEs for the updated variable names.

<a name="v2.2.1"></a>
# [v2.2.1](https://github.com/IBM/ansible-power-linux-sap/releases/tag/v2.2.1) - 18 Jul 2024

Expand Down Expand Up @@ -210,7 +227,8 @@ This release will add the following capabilities:
## Release Summary
Initial beta release of IBM Power Virtual Systems SAP with RISE collection, referred to as power_linux_sap

[Changes][v3.1.0]
[Changes][v3.1.1]
[v3.1.0]: https://github.com/IBM/ansible-power-linux-sap/compare/v3.1.1...v3.1.0
[v3.1.0]: https://github.com/IBM/ansible-power-linux-sap/compare/v3.1.0...v3.0.0
[v3.0.0]: https://github.com/IBM/ansible-power-linux-sap/compare/v3.0.0...v2.2.1
[v2.2.1]: https://github.com/IBM/ansible-power-linux-sap/compare/v2.2.1...v2.2.0
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Install the below collections.
|Collection|Version|
|----------|-------|
|redhat.sap_install| >= 1.3.7|
|community.general| >= 10.0.1|
|community.general| >= 10.1.0|
|ansible.posix| >= 1.5.4|
|ansible.utils| >= 4.1.0|

Expand Down
5 changes: 5 additions & 0 deletions docs/source/release_notes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -158,3 +158,8 @@ Version 3.1.0
Notes
* RFS configuration setup
* NFS client check fix

Version 3.1.1
Notes
* Minimum community.general version 10.1.0
* Skip pause for services only if status changed
2 changes: 1 addition & 1 deletion galaxy.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
namespace: "ibm"
name: "power_linux_sap"
version: 3.1.0
version: 3.1.1
readme: "README.md"
description: Collection of Ansible Roles for RHEL/SLES OS to prepare LPARs for installing SAP on Power Systems.
authors:
Expand Down
2 changes: 1 addition & 1 deletion requirements.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ collections:
type: galaxy

- name: community.general
version: ">=10.0.1"
version: ">=10.1.0"
type: galaxy

- name: ansible.utils
Expand Down
2 changes: 1 addition & 1 deletion roles/configure_network_management_services/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Install the below collections.
|Collection|Version|
|----------|-------|
|ansible.utils| >= 4.1.0|
|community.general| >= 10.0.1|
|community.general| >= 10.1.0|
|ansible.posix| >= 1.5.4|

# Role Variables
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,12 @@
ansible.builtin.lineinfile:
path: /etc/resolv.conf
line: nameserver {{ client_config.dns.dns_server_ip }}
register: nameserver_configured

- name: Pause for 60 sec
ansible.builtin.pause:
seconds: 60
when: nameserver_configured.changed

- name: Check for name resolution using dig command
ansible.builtin.command: dig -i www.google.com +short
Expand Down Expand Up @@ -143,10 +145,12 @@
state: restarted
enabled: true
changed_when: false
register: chrony_configured

- name: Pause for 60 sec
ansible.builtin.pause:
seconds: 60
when: chrony_configured.changed

- name: Verify Chrony configuration grepping for Leap status Normal using chronyc tracking
ansible.builtin.command: chronyc tracking | grep Leap | grep Normal
Expand Down
2 changes: 1 addition & 1 deletion roles/monitoring_sap/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Install the below collections.

|Collection|Version|
|----------|-------|
|community.general| >= 10.0.1|
|community.general| >= 10.1.0|

# # Role Variables

Expand Down
2 changes: 1 addition & 1 deletion roles/powervs_configure_os_for_sap/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Install the below collections.
|Collection|Version|
|----------|-------|
|redhat.sap_install| >= 1.3.7|
|community.general| >= 10.0.1|
|community.general| >= 10.1.0|
|ansible.posix| >= 1.5.4|

# Role Variables
Expand Down
2 changes: 1 addition & 1 deletion roles/powervs_os_registration/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Install the below collections.

|Collection|Version|
|----------|-------|
|community.general| >= 10.0.1|
|community.general| >= 10.1.0|

# Role Variables

Expand Down
2 changes: 1 addition & 1 deletion roles/powervs_storage_and_swap_setup/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ Install the below collections.

|Collection|Version|
|----------|-------|
|community.general| >= 10.0.1|
|community.general| >= 10.1.0|
|ansible.posix| >= 1.5.4|

# Role Variables
Expand Down
30 changes: 10 additions & 20 deletions roles/powervs_storage_and_swap_setup/tasks/disks-dict2list.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,18 @@
changed_when: false

- ansible.builtin.set_fact:
# noqa name[missing]
tmp_wwn_list: "{{ tmp_wwn_list | default([]) + item.stdout_lines }}"
tmp_wwn_list: "{{ tmp_wwn_list | default([]) + item.stdout_lines }}" # noqa name[missing]
loop: "{{ loop_for_wwn.results }}"

- ansible.builtin.debug:
# noqa name[missing]
var: loop_for_wwn.results
var: loop_for_wwn.results # noqa name[missing]

- name: Debug
ansible.builtin.debug:
var: tmp_wwn_list

- ansible.builtin.debug:
# noqa name[missing]
var: "{{ tmp_wwn_list | type_debug }}"
var: "{{ tmp_wwn_list | type_debug }}" # noqa name[missing]

- name: Set fact create a dict with pv and its type
ansible.builtin.set_fact:
Expand All @@ -38,34 +35,28 @@
- "{{ tmp_wwn_list }}"

- ansible.builtin.debug:
# noqa name[missing]
var: pv_listing_dm
var: pv_listing_dm # noqa name[missing]

- name: Create a file /root/tmp_file with pv listing content.
ansible.builtin.copy:
# noqa risky-file-permissions
content: "{{ pv_listing_dm }}"
content: "{{ pv_listing_dm }}" # noqa risky-file-permissions
dest: "/root/tmp_file"
changed_when: false

- ansible.builtin.raw: "cat /root/tmp_file | tr [{},] '\n' | tee /root/tmp_file_mod"
# noqa name[missing]
- ansible.builtin.raw: "cat /root/tmp_file | tr [{},] '\n' | tee /root/tmp_file_mod" # noqa name[missing]
changed_when: false

- ansible.builtin.raw: "cat /root/tmp_file_mod | sed 's/ //g' | sed 's/\"//g' | grep {{ item }} | sed 's/:{{ item }}//g' | tr '\n' ',' | sed 's/,$//g'"
# noqa name[missing]
register: tmp_wwn_var
register: tmp_wwn_var # noqa name[missing]
loop: "{{ disks_configuration.names | map('trim') | list }}"
changed_when: false

- ansible.builtin.set_fact:
# noqa name[missing]
wwn_list: "{{ wwn_list | default([]) + item.stdout_lines }}"
wwn_list: "{{ wwn_list | default([]) + item.stdout_lines }}" # noqa name[missing]
loop: "{{ tmp_wwn_var.results }}"

- ansible.builtin.debug:
# noqa name[missing]
var: wwn_list
var: wwn_list # noqa name[missing]

- name: Set fact create stripes list dictionary
ansible.builtin.set_fact:
Expand All @@ -77,8 +68,7 @@
- "{{ wwn_list }}"

- ansible.builtin.debug:
# noqa name[missing]
var: disks_config_mod
var: disks_config_mod # noqa name[missing]

- name: Execution of fs_creation role starts here. Iterate for each list created above
ansible.builtin.include_tasks: file-system-creation-core.yml
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,16 +54,13 @@

# Create a list based on multipath output.
- ansible.builtin.set_fact:
empty_list: "{{ empty_list | default([]) }}"
# noqa name[missing]
empty_list: "{{ empty_list | default([]) }}" # noqa name[missing]

- ansible.builtin.set_fact:
wwn_to_dm_list: "{{ empty_list | default([]) }}"
# noqa name[missing]
wwn_to_dm_list: "{{ empty_list | default([]) }}" # noqa name[missing]

- ansible.builtin.set_fact:
wwn_to_dm_list: "{{ wwn_to_dm_list | default([]) + item.stdout_lines }}"
# noqa name[missing]
wwn_to_dm_list: "{{ wwn_to_dm_list | default([]) + item.stdout_lines }}" # noqa name[missing]
loop: "{{ wwn_dm_list.results }}"

# Creating volume group.
Expand Down

0 comments on commit 8030c5d

Please sign in to comment.