Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/tolerate pod deployments #108

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Bugfix/tolerate pod deployments #108

merged 2 commits into from
Jul 4, 2024

Conversation

reggeenr
Copy link
Collaborator

@reggeenr reggeenr commented Jul 3, 2024

Bugfix to enable the metrics collector to handle standard kube deployments

@reggeenr reggeenr requested a review from qu1queee July 3, 2024 22:05
@kersten1
Copy link

kersten1 commented Jul 3, 2024

Hi! I don't feel authorized to approve this pr though

smoser-ibm
smoser-ibm approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@smoser-ibm smoser-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoser-ibm smoser-ibm merged commit 73f4c2b into main Jul 4, 2024
1 of 2 checks passed
@qu1queee qu1queee deleted the bugfix/tolerate-pod-deployments branch July 4, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoser-ibm smoser-ibm smoser-ibm approved these changes

@qu1queee qu1queee Awaiting requested review from qu1queee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reggeenr @kersten1 @smoser-ibm