Adding the ability to diable CSTG key #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ian-Nara
reviewed
May 14, 2024
| @@ -3094,6 +3093,55 @@ void cstgLogsInvalidAppName(String appName, Vertx vertx, VertxTestContext testCo | |||
| }); | |||
| } | |||
|
|
|||
| @Test | |||
| void catalogsDisabledAsUnauthorized(Vertx vertx, VertxTestContext testContext) throws NoSuchAlgorithmException, InvalidKeyException { | |||
There was a problem hiding this comment.
can it be prefixed with "cstg" to make the tests easier to search and group?
Ian-Nara
reviewed
May 14, 2024
| @@ -38,7 +38,8 @@ public enum ResponseStatus { | |||
| PayloadHasNoBody, | |||
| /* End of CSTG-related Status */ | |||
| Unknown, | |||
| NoActiveKey | |||
| NoActiveKey, | |||
| UNAUTHORIZED | |||
There was a problem hiding this comment.
The others are PascalCase
Ian-Nara
reviewed
May 14, 2024
| respJson -> { | ||
| assertEquals("Unauthorized", respJson.getString("message")); | ||
| testContext.completeNow(); | ||
| }); |
There was a problem hiding this comment.
I think we can also assertTokenStatusMetrics here
thomasm-ttd
reviewed
May 15, 2024
Ian-Nara
approved these changes
May 20, 2024
thomasm-ttd
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.