Add method OptOutStoreSnapshot.getAdIdOptOutTimestamp #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is to make OptOutStoreSnapshot testable. Calling toPartition on an empty heap causes an assertion failure. One place this happens is in the constructor for OptOutStoreSnapshot, making it untestable. To work around this, we use a null OptOutPartition.
* Add new endpoint to check opt out status by raw UIDs * Try loading optout deltas from local * Revert "Try loading optout deltas from local" This reverts commit d8e563a. * Add a switch to disable endpoint and hashmap loading * Add Snapshot store test for disabled status * Add test cases for optout status endpoint processing * Increase max request size to 5K. Refactor and update tests * Update opt out status test * Update default max size of opt out request
- Number of advertising IDs. - Time to query optout timestamp by advertising ID. - Time to query optout timestamp by first-level hash. - Labelled by the Bloom filter's answer. - Time to process delta files. - Time to process partition files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method returns the earliest optout timestamp for a given advertising ID.
One commit is a workaround for an issue where calling
toPartitionon an empty heap throws an assertion error. This issue has laid dormant because we didn't have any tests coveringOptOutStoreSnapshotuntil now. The workaround is to usenullinstead, so we need some extra checks.Included are some small improvements:
suminstead ofreducefor clarity.OptOutStoreSnapshot.fsLocalfromICloudStoragetoDownloadCloudStoragefor easier testing.ClocktoOptOutStoreSnapshotfor easier testing.