Add CSTG tests #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmsdelmundo
reviewed
Jan 8, 2024
| @@ -182,6 +201,125 @@ public JsonNode v2TokenGenerateUsingPayload(String payload, boolean asOldPartici | |||
| return v2DecryptEncryptedResponse(encryptedResponse, envelope.nonce(), getClientApiSecret(asOldParticipant)); | |||
| } | |||
|
|
|||
| public JsonNode v2ClientSideTokenGenerate(String requestBody, boolean useValidOrigin) throws Exception { | |||
| final byte[] serverPublicKeyBytes = base64ToByteArray(CLIENT_SIDE_TOKEN_GENERATE_SERVER_PUBLIC_KEY.substring(PUBLIC_KEY_PREFIX_LENGTH)); | |||
There was a problem hiding this comment.
Not a big issue, but final isn't really needed for local variables
There was a problem hiding this comment.
I'm a fan because it reduces cognitive overhead, no need to ask: "is this variable intentionally mutable / going to be reassigned later?"
There was a problem hiding this comment.
Yep that's fine too, I don't have very strong opinions on either
| private static final String CLIENT_API_KEY = EnvUtil.getEnv("UID2_E2E_API_KEY"); | ||
| private static final String CLIENT_API_SECRET = EnvUtil.getEnv("UID2_E2E_API_SECRET"); | ||
| private static final String CLIENT_API_KEY_BEFORE_OPTOUT_CUTOFF = EnvUtil.getEnv("UID2_E2E_API_KEY_OLD"); | ||
| private static final String CLIENT_API_SECRET_BEFORE_OPTOUT_CUTOFF = EnvUtil.getEnv("UID2_E2E_API_SECRET_OLD"); | ||
| private static final String CLIENT_SIDE_TOKEN_GENERATE_SUBSCRIPTION_ID = EnvUtil.getEnv("UID2_E2E_SUBSCRIPTION_ID"); | ||
| private static final String CLIENT_SIDE_TOKEN_GENERATE_SERVER_PUBLIC_KEY = EnvUtil.getEnv("UID2_E2E_SERVER_PUBLIC_KEY"); | ||
| private static final String CLIENT_SIDE_TOKEN_GENERATE_ORIGIN = EnvUtil.getEnv("UID2_E2E_ORIGIN"); |
There was a problem hiding this comment.
Do both valid and invalid origins have to be passed in dynamically? Can they be hardcoded instead?
jon8787
reviewed
Jan 8, 2024
| } | ||
| return keyPairGenerator.genKeyPair(); | ||
| } | ||
|
|
There was a problem hiding this comment.
As @gmsdelmundo mentioned, any way to share this code with Operator (test) code?
gmsdelmundo
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds tests for CSTG. They cover the happy path and the case of an invalid origin.