Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply needed fixes and improvements #90

Merged
merged 15 commits into from
Dec 14, 2024
Merged

Apply needed fixes and improvements #90

merged 15 commits into from
Dec 14, 2024

Conversation

R-Santev
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Dec 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12319554263

Details

  • 27 of 28 (96.43%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 87.804%
Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/HydraStaking/HydraStaking.sol 11 12 91.67%
Files with Coverage Reduction New Missed Lines %
contracts/common/Liquid/Liquid.sol 1 75.0%
Totals Coverage Status
Change from base Build 12140066631: 0.2%
Covered Lines: 1226
Relevant Lines: 1323
💛 - Coveralls

SamBorisov
SamBorisov requested changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@SamBorisov SamBorisov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix falling test

contracts/HydraDelegation/Delegation.sol Outdated Show resolved Hide resolved
contracts/HydraDelegation/Delegation.sol Outdated Show resolved Hide resolved
contracts/HydraStaking/HydraStaking.sol Show resolved Hide resolved
contracts/LiquidityToken/LiquidityToken.sol Show resolved Hide resolved
contracts/PriceOracle/libs/SortedPriceList.sol Outdated Show resolved Hide resolved
Vitomir2
Vitomir2 requested changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@Vitomir2 Vitomir2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @SamBorisov suggested, fix the failing tests. Additionally, check the other failing Actions. Lastly, I have left some minor comments.

docs/HydraChain/HydraChain.md Outdated Show resolved Hide resolved
docs/HydraChain/HydraChain.md Outdated Show resolved Hide resolved
@R-Santev R-Santev merged commit a000cdf into main Dec 14, 2024
7 checks passed
@R-Santev R-Santev deleted the fixes-and-improvements branch December 14, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamBorisov SamBorisov SamBorisov approved these changes

@Vitomir2 Vitomir2 Vitomir2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@R-Santev @coveralls @Vitomir2 @SamBorisov