281 fix vested staking #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11956212792Details
💛 - Coveralls |
R-Santev
approved these changes
Nov 19, 2024
R-Santev
requested changes
Nov 21, 2024
| @@ -59,6 +59,15 @@ abstract contract VestedStaking is IVestedStaking, Staking, Vesting { | |||
| _stake(msg.sender, msg.value); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
IVestedStaking doesn't inherit IStaking
| * @inheritdoc IHydraStaking | ||
| */ | ||
| function stake() public payable override(IHydraStaking, Staking, VestedStaking) { | ||
| VestedStaking.stake(); |
There was a problem hiding this comment.
Why not using super here?
| * @notice Stakes sent amount. | ||
| * @dev If user has active vested position, it will revert. | ||
| */ | ||
| function stake() external payable; |
There was a problem hiding this comment.
This must be in IStaking
| */ | ||
| function stake() public payable virtual override { | ||
| if (vestedStakingPositions[msg.sender].isActive()) { | ||
| revert StakeRequirement({src: "stake", msg: "IN_ACTIVE_POSITION"}); |
There was a problem hiding this comment.
super is not called here
SamBorisov
force-pushed
the
281-fix-vested-staking
branch
from
8f8e9c6 to
cb1cc1d
Compare
R-Santev
approved these changes
Nov 21, 2024
SamBorisov
force-pushed
the
281-fix-vested-staking
branch
from
ebaa88f to
fbda956
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No top-up is allowed on vested staking.
Now Delegtarts can delegate to the validator even after minStake is changed.
Clear stakingRewardsHistory, before opening vestedStaking.
Handle debt by requiring a staker to provide liquidity tokens, before opening a position!